Implement basic command line switch preprocessor for Cobalt #4930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjungm
requested review from
yell0wd0g,
TyHolc,
kaidokert,
y4vor and
andrewsavage1
and removed request for
TyHolc
TyHolc
approved these changes
Feb 24, 2025
arjungm
force-pushed
the
arjun-rework-cobalt-launch-arguments
branch
from
b84967e to
25fa83f
Compare
y4vor
reviewed
Feb 24, 2025
| {switches::kRemoteAllowOrigins, "http://localhost:9222"}, | ||
| }); | ||
|
|
||
| class CommandLinePreprocessor { |
There was a problem hiding this comment.
How about we move this class in a separate file and add a unit test?
| }); | ||
|
|
||
| // Switches with parameters. May require special handling with passed in values. | ||
| const auto kCobaltParamSwitches = base::CommandLine::SwitchMap({ |
There was a problem hiding this comment.
I doubt this is trivially destructible go/cstyle#Static_and_Global_Variables
| // This flag is added specifically for m114 and should be removed after | ||
| // rebasing to m120+ | ||
| #if BUILDFLAG(IS_ANDROID) | ||
| switches::kUserLevelMemoryPressureSignalParams, |
There was a problem hiding this comment.
Are these flags used on Android? I thought those flags were in CobaltActivity.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/397982418